2009/5/28 Baruch Siach <baruch@xxxxxxxxxx>: >> > +static int dw_i2c_probe(struct platform_device *pdev) >> >> Can you tag this with __init? > > OK. __devinit is probably better. (and same for exit) Look in include/linux/init.h for the use of these macros. There are many, many erroneous drivers in the kernel, and I think it is mainly due to the fact that __devinit looks like it has something to do with "devices", while it does not. It should be named __hotpluginit or something so one can see what it actually is. I don't think any platform_device tagged with __devinit is correct really, platform_device:s cannot be hotplugged that's against the definition of a platform_device. I should make more cleanup patches regarding this... Linus -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
