Hi Linus,
On Thu, May 28, 2009 at 09:32:37AM +0200, Linus Walleij wrote:
> 2009/5/28 Baruch Siach <baruch@xxxxxxxxxx>:
>
> >> > +static int dw_i2c_probe(struct platform_device *pdev)
> >>
> >> Can you tag this with __init?
> >
> > OK. __devinit is probably better.
>
> I don't think any platform_device tagged with __devinit is
> correct really, platform_device:s cannot be hotplugged that's
> against the definition of a platform_device.
Doesn't this __devinit have something to do with the ability to compile the
driver as a module (as is the case here)? See for example
drivers/watchdog/omap_wdt.c and commit
0e3912c75f42986c17d955542247bf04c6eef738
> I should make more cleanup patches regarding this...
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
