Re: [PATCH] gpio: mxs: implement get_direction callback

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

On Mon, Nov 17, 2014 at 03:45:00PM +0100, Janusz Użycki wrote:
> W dniu 2014-11-17 o 10:26, Richard Genoud pisze:
> >And, honestly, I'm not sure dev_name(dev) is a good name.
> >Having something like dev_name(dev)_port_id_CTS may be better.
> >
> 
> For names other than device's or driver's name I would need to allocate
> string. Is it so important? You can simple check the interrupt and
> corresponding port:
> cat /proc/interrupts
>  50:          0  gpio-mxs  21  80072000.serial
>  80:          0  gpio-mxs  18  8006c000.serial
>  81:          0  gpio-mxs  19  8006c000.serial
>  83:          0  gpio-mxs  21  8006c000.serial
>  84:          0  gpio-mxs  22  8006c000.serial
I'd say this is good enough.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html