Re: [PATCH] Several compat additions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 14 May 2006, Mauro Carvalho Chehab wrote:
> Em Dom, 2006-05-14 ās 11:54 +0200, Johannes Stezenbach escreveu:
> > Did you also look at the bunch of patches at the start of the thread?
> > http://linuxtv.org/pipermail/linux-dvb/2006-May/010195.html
> Argh! I only looked at mutex issue!

That big mutex patch was several weeks older than the recent series.

> > +#include "compat.h"
> > +#if !defined(V4LCOMPAT_NO_USB_INPUT)
> Argh! We currently don't use #if !defined. Instead, we use #ifndef.

Ok, I'll use that.  I was using V4LCOMPAT_* instead of kernel versions tests
because it's shorter, makes it clear what the test is for, and doesn't require
keeping all the different version numbers straight.  For instance there is a
test in tuner-core.c for 2.5.0 that should be for 2.6.0.

If this makes it too hard for gentree.pl, I can go back.

_______________________________________________

linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux