Em Dom, 2006-05-14 às 11:54 +0200, Johannes Stezenbach escreveu: > > > Please wait for Mauro to ACK, they touch a lot of v4l > > > code, and I'm not sure if Mauro's scripts handle the > > > removal of the new compat stuff when creating patches > > > for sending to Linus. > > > > For my scripts, this won't hurt. The filtering stuff is done by > > v4l/scripts/gentree.pl inside the tree. > > > > The basic question here is: All V4L and DVB developers comfortable with > > this? If so, we can proceed and apply it. Otherwise, please manifest > > within the next 3 days. > > Did you also look at the bunch of patches at the start of the thread? > http://linuxtv.org/pipermail/linux-dvb/2006-May/010195.html Argh! I only looked at mutex issue! > > They have stuff like: > > diff -r e9383e768f51 -r 40ba20975e81 linux/drivers/media/video/usbvideo/konicawc.c > --- a/linux/drivers/media/video/usbvideo/konicawc.c Fri May 12 15:26:41 2006 -0700 > +++ b/linux/drivers/media/video/usbvideo/konicawc.c Fri May 12 15:40:23 2006 -0700 > @@ -16,7 +16,11 @@ > #include <linux/module.h> > #include <linux/init.h> > #include <linux/input.h> > +#define V4LCOMPAT_USB_INPUT /* Include usb_input code in compat.h */ > +#include "compat.h" > +#if !defined(V4LCOMPAT_NO_USB_INPUT) Argh! We currently don't use #if !defined. Instead, we use #ifndef. If the patches are including newer vars to be checked, gentree.pl should also be patched to discard those newer codes. I'll review again the patch series, based on Trent posts at DVB ml, c/c to Mailing lists. > > Johannes Cheers, Mauro. _______________________________________________ linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
