Em Sáb, 2006-05-13 às 02:18 +0200, Johannes Stezenbach escreveu: > On Sat, May 13, 2006, Andrew de Quincey wrote: > > On Saturday 13 May 2006 00:27, Trent Piepho wrote: > > > Here are patches for four different kernel compat issues, plus a patch to > > > update versions.txt. > > > > > > Most were straight forward. The change for the usb_input.h was not so > > > obvious, I tried to come up something that had the least impact on the > > > drivers. > > > > > > Some drivers don't have compat code for changes made to struct i2c_driver > > > in 2.6.16. They will still compile and insert, but leave important fields > > > uninitialized, which can lock the kernel. I didn't make them work with > > > older kernels, but did adjust versions.txt to be correct. > > > > All these look good to me - if no one else complains I'll apply 'em. > > > > Does anyone have any objections to Trent's other mutex/sempahore compat patch > > at: > > http://www.linuxtv.org/pipermail/linux-dvb/2006-April/009510.html > > > > If not, I'll apply that too.... > > Please wait for Mauro to ACK, they touch a lot of v4l > code, and I'm not sure if Mauro's scripts handle the > removal of the new compat stuff when creating patches > for sending to Linus. I'm CC also V4L ML, since it will affect future developments at the tree. After the patch, usage of "mutex" should be restricted to "struct mutex". All other usage for mutex word is forbidden, since gpp will replace all "mutex" occorences to "semaphore" if kernel <2.6.16. The advantage is that it will remove tests like: #if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15) struct mutex hab_mutex; #else struct semaphore hab_mutex; #endif for every mutex declaration at the code, making the code cleaner. For my scripts, this won't hurt. The filtering stuff is done by v4l/scripts/gentree.pl inside the tree. The basic question here is: All V4L and DVB developers comfortable with this? If so, we can proceed and apply it. Otherwise, please manifest within the next 3 days. > > Johannes Cheers, Mauro. _______________________________________________ linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
