Re: [PATCH] [crypto] load the SHA1[1|256] module by an alias

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 05, 2007 at 03:50:56PM +0200, Sebastian Siewior wrote:
>
> I did not find a module_mutex. We hold a readlock of crypto_alg_sem
> within the crypto subsystem and request_module() increments
> kmod_concurrent (which may not exceed a certain limit). 

Yes you're right.  The module_mutex (in kernel/module.c) is
dropped for the init call so the dead-lock won't actually occur.
However, it's still good to remove this code since doing a nested
modprobe of "sha" within a modprobe of "sha" just feels wrong.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux