* Herbert Xu | 2007-10-03 15:35:22 [+0800]: >On Sun, Sep 30, 2007 at 02:42:39PM +0200, Sebastian Siewior wrote: >> >> Herbert, I tried to implement a MODULE_PRIO() macro which would be used >> by the module loader and I noticed that it may not be required. >> If there are two modules providing the same alias and we modprobe that >> alias than modprobe will load both of them. It may be a waste of memory >> if we load the generic algorithm and the assembly optimized one. >> However, it would be good for some hardware drivers which need the >> generic implementation for some "corner cases". >> What do you thing? > >I think you're brilliant! > >Could you please do a patch to rename aes.c to aes-generic.c and >add the appropriate alias to it? Please add the aes alias to padlock >and geode while you're at it. I am sorry that I did not reply earlier but I was busy framing that email :) I send out rename patches for aes, des (s390 hw driver available) and sha1+252 (s390 + via padlock hw). Two last questions: - What about the i386 assembly vs generic implementation? Do you prefer the patch that I have send earlier (choose the assembly by default making the generic optional) or do you want both of them loaded at the same time. - What might be the best fallback strategy for the s390 + geode aes driver? I tried to move the key size to the algorithm request function what works good most of the time. All users except the wlan stack do alloc cipher followed by setkey in the same function. The benefit would be that you don't return a cipher that is not able to handle certain key sizes (and you don't have to implement the fallback in every driver (2 right now)) separately. I started to implement a fallback within the driver (two is not that much right now) and wanted to make sure that this is the prefered way of fixing this. >Thanks, Sebastian - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
