* Herbert Xu | 2007-10-05 16:57:44 [+0800]: >This patch is correct per se but it combined with the code in >padlock-sha can cause a dead-lock. Padlock-sha tries to load >the generic sha module in its init function. At this point it >is still holding the module_mutex so the probe will dead-lock. I did not find a module_mutex. We hold a readlock of crypto_alg_sem within the crypto subsystem and request_module() increments kmod_concurrent (which may not exceed a certain limit). >The probe is actually pointless since we can always probe when >the algorithm is actually used which does not lead to dead-locks >like this. Right. >So please delete the padlock_sha_check_fallbacks code in your >patch to make it load correctly. okey, updated patch will follow. >Cheers, Sebastian - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html