Re: [PATCH #upstream-fixes] libata: disable ATAPI AN by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/19/2010 09:38 AM, Tejun Heo wrote:
There are ATAPI devices which raise AN when hit by commands issued by
open().  This leads to infinite loop of AN ->  MEDIA_CHANGE uevent ->
udev open() to check media ->  AN.

Both ACS and SerialATA standards don't define in which case ATAPI
devices are supposed to raise or not raise AN.  They both list media
insertion event as a possible use case for ATAPI ANs but there is no
clear description of what constitutes such events.  As such, it seems
a bit too naive to export ANs directly to userland as MEDIA_CHANGE
events without further verification (which should behave similarly to
windows as it apparently is the only thing that some hardware vendors
are testing against).

This patch adds libata.atapi_an module parameter and disables ATAPI AN
by default for now.

Signed-off-by: Tejun Heo<tj@xxxxxxxxxx>
Cc: Kay Sievers<kay.sievers@xxxxxxxx>
Cc: Nick Bowler<nbowler@xxxxxxxxxxxxxxxx>
Cc: David Zeuthen<david@xxxxxxxx>
Cc: stable@xxxxxxxxxx
---
  drivers/ata/libata-core.c |    7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux