Hi, On Sat, 10 Jan 2009, Adeodato Simó wrote: > * Johannes Schindelin [Sat, 10 Jan 2009 11:19:43 +0100]: > > > > test_expect_success '--signoff' ' > > > echo "yet another content *narf*" >> foo && > > > - echo "zort" | ( > > > - test_set_editor "$TEST_DIRECTORY"/t7500/add-content && > > > - git commit -s -F - foo > > > - ) && > > > + echo "zort" | git commit -s -F - foo && > > > git cat-file commit HEAD | sed "1,/^$/d" > output && > > > test_cmp expect output > > > ' > > > AFAICT this still tests if -F - launches an editor, except that it _does_ > > launch the editor, waiting for the user to quit the editor. Which is bad. > > The default value of VISUAL for the test suite is ":" AFAICS. Hence, > even if it's called, it will return immediately. Ah. Okay then. Sorry for the noise, Dscho