Hi, On Fri, 9 Jan 2009, Adeodato Simó wrote: > diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh > index 6e18a96..5998baf 100755 > --- a/t/t7500-commit.sh > +++ b/t/t7500-commit.sh > @@ -149,10 +149,7 @@ EOF > > test_expect_success '--signoff' ' > echo "yet another content *narf*" >> foo && > - echo "zort" | ( > - test_set_editor "$TEST_DIRECTORY"/t7500/add-content && > - git commit -s -F - foo > - ) && > + echo "zort" | git commit -s -F - foo && > git cat-file commit HEAD | sed "1,/^$/d" > output && > test_cmp expect output > ' AFAICT this still tests if -F - launches an editor, except that it _does_ launch the editor, waiting for the user to quit the editor. Which is bad. In the end I think it is not worth all that effort (as the issue was fixed long time ago, probably even before builtin-commit entered 'next'), so I'd just leave the test as-is, documenting why the editor is set to add-content. Ciao, Dscho
