* Johannes Schindelin [Sat, 10 Jan 2009 11:19:43 +0100]:
> Hi,
Hello,
> > test_expect_success '--signoff' '
> > echo "yet another content *narf*" >> foo &&
> > - echo "zort" | (
> > - test_set_editor "$TEST_DIRECTORY"/t7500/add-content &&
> > - git commit -s -F - foo
> > - ) &&
> > + echo "zort" | git commit -s -F - foo &&
> > git cat-file commit HEAD | sed "1,/^$/d" > output &&
> > test_cmp expect output
> > '
> AFAICT this still tests if -F - launches an editor, except that it _does_
> launch the editor, waiting for the user to quit the editor. Which is bad.
The default value of VISUAL for the test suite is ":" AFAICS. Hence,
even if it's called, it will return immediately.
If it would be called, without my patch the "--signoff" test would fail,
but there would be no obvious reason as to why. Seeing "editor not
invoked if -F is given FAILED" is much more clear IMHO.
Also note that there plenty of places in the test suite where -F is
used, but VISUAL is not set explicitly.
Cheers,
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
Excuse me for thinking a banana-eating contest was about eating a banana!
-- Paris Geller
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
