Hi, On Mon, 29 Dec 2008, Junio C Hamano wrote: > Adeodato Simó <dato@xxxxxxxxxxxxxx> writes: > > > I was reading this test case, and it took a small bit to figure out > > the editor was not being used at all. I hope there was no hidden > > reason for it to be there, and it can go away. > > That 'zort' came from 1320857 (builtin-commit: fix --signoff, > 2007-11-11), and I _think_ it is trying to make sure that presense of > "-F -" makes the editor not to trigger. > > Dscho? Hmm. Obviously, I failed to document properly why I tested the editor, but I think it makes sense to assume that -F still triggered an interactive editor at some stage in the development of builtin commit. I do not have anything against separating that issue into another test case, but I am strongly opposed to simply removing it. Ciao, Dscho
