Hi, On Sat, 10 Jan 2009, Thomas Rast wrote: > Johannes Schindelin wrote: > > BTW I did not really think about the issue you raised about the newlines, > > as I seemed to remember that the idea was to substitute all non-word > > characters with newlines, so that the offsets in the substituted text are > > the same as in the original text. > > Ok, so here's a very simple example: Suppose you have the word regex > 'x+|y+' and compare these two lines: > > A: xxyyxy > B: xyxyy Ah, I see. > > So I still find your patch way too large > > I can't think of a simpler way to do it, and yours unfortunately doesn't > work. Well, the thing I tried to hint at: it is not good to have a monster patch, as nobody will review it. In your case, I imagine it would be much easier to get reviewers if you had patch 1/4 refactor color-words to allow for 0-character word boundaries patch 2/4 allow regular expressions to define what makes a word patch 3/4 add option to specify word boundary regexps via attributes patch 4/4 test word boundary regexps And I admit that I documented the code lousily, but that does not mean that you should repeat that mistake. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
