Ævar Arnfjörð Bjarmason wrote: > I just try to > (hopefully mostly helpfully) to point out common things that > contradict the docs we have Thanks for doing so, by the way. One of the best ways to make sure the docs are sane is to use them. When a guideline is unclear, probably I should have been updating the docs instead of dispensing advice. How about something like this? diff --git a/t/README b/t/README index 410499a..f347de7 100644 --- a/t/README +++ b/t/README @@ -235,7 +235,9 @@ Do's, don'ts & things to keep in mind ------------------------------------- Here are a few examples of things you probably should and shouldn't do -when writing tests. +when writing tests. If you are editing an existing test script and have +the time for it, consider updating the script to follow these guidelines +in a separate patch before adding your new test. Do: -- -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html