Matthieu Moy wrote: > Not sure what is the gain by doing so, and the vast majority of tests > already there use the style of Greg's patch ... Right. The usual rule when contributing to an existing project is "imitate the surruounding code", but there is often a tension between global style guidelines and the local conventions. In this case I have to agree with Matthieu: the test script is easier to read if it follows a single, consistent style. The cleanup can happen another day. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html