Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > On Wed, Aug 18, 2010 at 09:29, Greg Brockman <gdb@xxxxxxx> wrote: > >> +cat >expect <<EOF >> +The following paths are ignored by one of your .gitignore files: >> +ignored-dir >> +Use -f if you really want to add them. >> +fatal: no files added >> +EOF > > Please make this a test, per this bit in t/README: > > - Put all code inside test_expect_success and other assertions. > > Even code that isn't a test per se, but merely some setup code > should be inside a test assertion. Not sure what is the gain by doing so, and the vast majority of tests already there use the style of Greg's patch ... -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html