On Tue, Apr 14, 2009 at 01:46, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Michael Witten <mfwitten@xxxxxxxxx> writes: > >> The usage text for --smtp-server currently has <host:port>, which >> doesn't work when 'ssl' is used for the connection to the server. > > Ah, I see. But it does work when ssl is not used, right? Right. > A possible solution would be one of: > > - support host:port in SSL codepath (shouldn't it be trivial?); Extremely trivial. > - split the description in the documentation to clarify it does not work > for SSL; or > > - remove host:port support to make both consistent. > > To me, the last one makes the least sense. Is that the approach you are > taking? That is SORT OF the approach I took. I got lazy and didn't care to make <host:port> work for SSL, because there is already --smtp-server-port and by just replacing <host:port> with <host> in the USAGE text, the whole <host:port> notation was effectively deprecated but still usable as before. Genius, right? Grade *A* laziness. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html