Michael Witten <mfwitten@xxxxxxxxx> writes: > All usage text lines should be < 80 characters. > > A port number in --smtp-server is no longer handled, > so the suggestion has been removed. That makes it sound like there is a regression. require Net::SMTP; $smtp ||= Net::SMTP->new((defined $smtp_server_port) ? "$smtp_server:$smtp_server_port" : $smtp_server); and because Net::SMTP is a subclass of IO::Socket::INET, I'd assume that this use will accept smtp_server=there:submission when $smtp_server_port is undef. > ---in-reply-to=<identifier>:: > +--in-reply-to=<message-id>:: Changes along this line in your patch looked sensible, except for the "identity" one which is a bit iffy. Other than that I think the patch is sane. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html