On Mon, Apr 13, 2009 at 15:51, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Michael Witten <mfwitten@xxxxxxxxx> writes:
>
>> All usage text lines should be < 80 characters.
>>
>> A port number in --smtp-server is no longer handled,
>> so the suggestion has been removed.
>
> That makes it sound like there is a regression.
>
> require Net::SMTP;
> $smtp ||= Net::SMTP->new((defined $smtp_server_port)
> ? "$smtp_server:$smtp_server_port"
> : $smtp_server);
>
> and because Net::SMTP is a subclass of IO::Socket::INET, I'd assume that
> this use will accept smtp_server=there:submission when $smtp_server_port
> is undef.
I may have been concerned that the SSL connection code doesn't support
a host:port specification, so I thought it would be easier not to
advertise it:
> if ($smtp_encryption eq 'ssl') {
> $smtp_server_port ||= 465; # ssmtp
> require Net::SMTP::SSL;
> $smtp ||= Net::SMTP::SSL->new($smtp_server, Port => $smtp_server_port);
> }
>> ---in-reply-to=<identifier>::
>> +--in-reply-to=<message-id>::
>
> Changes along this line in your patch looked sensible, except for the
> "identity" one which is a bit iffy.
The change to <id> ? Well, I did so, because the usage text uses <id>
for compactness; I think everything else matches.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html