Re: [PATCH RFC3 05/13] send-email: Cleanup the usage text and docs a bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 14, 2009 at 00:39, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Michael Witten <mfwitten@xxxxxxxxx> writes:
>
>>>> A port number in --smtp-server is no longer handled,
>>>> so the suggestion has been removed.
>> ...
>> I may have been concerned that the SSL connection code doesn't support
>> a host:port specification, so I thought it would be easier not to
>> advertise it:
>
> These two statements contradict with each other.  Please make up your mind
> ;-).

I'm confused.

The usage text for --smtp-server currently has <host:port>, which
doesn't work when 'ssl' is used for the connection to the server.
However, the other forms of connection DO work when a <host:port>
address is given.

I set out to add <host:port> support for SSL, but then decided that
people should just use the --smtp-server-port input. It already works
for every connection method and why else have it? However, rather than
remove ALL support for <host:port>, I just changed <host:port> to
<host> in the usage text for --smtp-server.

So, effectively, I've deprecated <host:port> by changing the
documentation, but the code hasn't changed. Would you rather support
<host:port> for everything?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]