Re: Fedora 33 System-Wide Change proposal: CMake to do out-of-source builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/17/20 8:41 AM, Igor Raits wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Wed, 2020-06-17 at 01:38 +0200, Kevin Kofler wrote:
James Cassell wrote:
If you're doing this, might I suggest reversing the condition so
the new
way is in the "else" part, hence "default"?

The problem is that this results in a counterintuitive &&, as in:
%if 0%{?fedora} <= 32 && 0%{?rhel} <= 8
(by de Morgan's law, or if you want to analyze it directly, because
0%{?rhel} <= 8 will always be true on Fedora).

%if (0%{?rhel} && 0%{?rhel}) <= 8 || (0%{?fedora} && 0%{?fedora} <= 32)


How about something like this instead? :D

%if %{defined cmake_install}
..
%endif

Or if referring to a macro of a different stage seems ugly, add a %cmake_setup macro for the task (and make %cmake a compat alias to that).

	- Panu -
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux