-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On Wed, 2020-06-17 at 01:38 +0200, Kevin Kofler wrote:
> James Cassell wrote:
> > If you're doing this, might I suggest reversing the condition so
> > the new
> > way is in the "else" part, hence "default"?
>
> The problem is that this results in a counterintuitive &&, as in:
> %if 0%{?fedora} <= 32 && 0%{?rhel} <= 8
> (by de Morgan's law, or if you want to analyze it directly, because
> 0%{?rhel} <= 8 will always be true on Fedora).
%if (0%{?rhel} && 0%{?rhel}) <= 8 || (0%{?fedora} && 0%{?fedora} <= 32)
> > I've run into issues rebuilding packages because there was such a
> > condition from a decade ago and I didn't have %fedora defined
> > because I
> > was trying to build it for another distro. (Common issue amongst
> > the ruby
> > packages.)
>
> Then you will always get the conditional for the oldest Fedora (no
> matter
> what is the %if and what the %else part) because 0%{?fedora} will be
> 0, by
> design.
>
> The specfiles in Fedora dist-git are either only for Fedora or for
> Fedora
> and RHEL/CentOS. They are not expected to work on any other distro.
While this is true, I know that some spec files are taken as-is to
openSUSE and Mageia. So it would be nice to have same and simple spec
files that work across multiple distributions.
> Kevin Kofler
> _______________________________________________
> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
> https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
- --
Igor Raits <ignatenkobrain@xxxxxxxxxxxxxxxxx>
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEcwgJ58gsbV5f5dMcEV1auJxcHh4FAl7prRMACgkQEV1auJxc
Hh4Hqw/+P6sboNTE3HXfqaPGiG06rzG69crm4LcDaDP2iwOHbXE43wY2+/gTNIaW
pl4hjIcoVH9ANJMQK56bvqHZYgl2z2PZ1MrlYOlAWVOi9CgDRqAX5toS6ivXiBWA
FbcDVWrYtbM/AL+Md0FFnEjjEZvAbXMBfDwAYcQc1Z/tjFHVYW0sCLg1H3XkZe21
3x3av3RH6TTrd7BQWa7DalRv5DJVbrrIqwpRwZmeiK9L2w2vJXGfkLKBQ/Tm0v87
SUZQ2OE+MrgGkF9CxW9z4rmSPzeQyNSAycL11SoyIBxXMIqnUeL/GdezK7mJaofS
PSlSz4hljSZqI+4kRbH4FMB0CSJz4xIJzGL1DAw0X8W2SzWoM69n3r7z4TQtX9Tv
jAf7MxSmY7mhDBnP6ePS5ecTOdvIQ5T0fdqUy8ATqLjnb3gq+2TVQJeF1eezHuMx
/E7OfLXczqpeg/vs0So4T91b2/lW/7zJicG+81Vw7efDHBJPMpp0YxXpQr8MOwwz
ALVG8OZU2KuYQnZ6OyJi3xB/3P2MDkPjq0G5revzmzirq6IkrB4d8CuuK8jq4gI7
wS81Re+Z0jU9oUKnT+5nUsRu6dC8iTM+j6qrCMGvhif1wgKlOM6FtR7MysZCwH34
ll+OXRvryP7QnRwacpDneh1OGxBz6JzBLXVdtsz5jWdErOFb4TQ=
=QAkM
-----END PGP SIGNATURE-----
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
