Re: Fedora 33 System-Wide Change proposal: CMake to do out-of-source builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



James Cassell wrote:
> If you're doing this, might I suggest reversing the condition so the new
> way is in the "else" part, hence "default"?

The problem is that this results in a counterintuitive &&, as in:
%if 0%{?fedora} <= 32 && 0%{?rhel} <= 8
(by de Morgan's law, or if you want to analyze it directly, because 
0%{?rhel} <= 8 will always be true on Fedora).

> I've run into issues rebuilding packages because there was such a
> condition from a decade ago and I didn't have %fedora defined because I
> was trying to build it for another distro. (Common issue amongst the ruby
> packages.)

Then you will always get the conditional for the oldest Fedora (no matter 
what is the %if and what the %else part) because 0%{?fedora} will be 0, by 
design.

The specfiles in Fedora dist-git are either only for Fedora or for Fedora 
and RHEL/CentOS. They are not expected to work on any other distro.

        Kevin Kofler
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux