On Tue, Jun 16, 2020, at 9:16 AM, Kevin Kofler wrote:
> Michael Catanzaro wrote:
> > Kevin, the goal is to *simply* these packages:
> >
> > mkdir -p %{_target_platform}
> > pushd %{_target_platform}
> > %cmake <package-specific flags go here>
> > popd
> >
> > It's four lines. We get to simplify it down to one line. Proposal
> > owners are provenpackagers and say they will try to fix affected
> > packages. Fine by me?
>
> In the real world, it will end up as:
>
> %if 0%{?fedora} > 32 || 0%{?rhel} > 8
> %cmake
> %else
> mkdir %{_target_platform}
> pushd %{_target_platform}
> %cmake ..
> popd
> %endif
>
If you're doing this, might I suggest reversing the condition so the new way is in the "else" part, hence "default"? I've run into issues rebuilding packages because there was such a condition from a decade ago and I didn't have %fedora defined because I was trying to build it for another distro. (Common issue amongst the ruby packages.)
V/r,
James Cassell
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
