I must agree with Kevin that taking every single commit message and putting it into changelog without further tweaking
might just produce lots of redundant and not really desired lines in the output. But I think something still can be done. When you invoke `rpkg tag` (the same goes for `fedpkg tag`), it brings up an editing window where you can edit a tag
message. So we could generate the commit messages into this window where the user could edit them.
The {{{ git_change_log }}} (or just {{{ git_changelog }}}) macro would then use exactly those tag messages
The {{{ git_change_log }}} (or just {{{ git_changelog }}}) macro would then use exactly those tag messages
(for each tag) to generate the final change log into the spec file.
On Sat, Feb 10, 2018 at 12:54 PM, Kevin Kofler <kevin.kofler@xxxxxxxxx> wrote:
David Sommerseth wrote:
> I doubt Koji was primarily built for "does this work?"-builds. It exists
> to build proper packages targeting Fedora repositories.
But that is the point, to build a proper package:
do {
try build;
} while (!build succeeded);
and the output is a working package.
> To me this is backwards and is lacking some logic. If you push things
> which does not build properly, you also waste a build.
That is a build attempt that would have had to happen anyway. Otherwise, how
do I know that it doesn't build.
The point is, the above optimized loop needs n build attempts. What you
propose doing needs n+1 build attempts to get the exact same package.
Kevin Kofler
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@lists.fedoraproject.org
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
