On Tue, Jun 10, 2014 at 06:21:00PM +0100, Matthew Garrett wrote: > On Tue, Jun 10, 2014 at 06:14:03PM +0100, Richard W.M. Jones wrote: > > On Tue, Jun 10, 2014 at 06:00:05PM +0100, Matthew Garrett wrote: > > > ExcludeArch implies that it's acceptable that it doesn't build on ARM > > > and removes the incentive for anyone to fix it. It's not. > > > > There's a process for handling this, which is to create (if required) > > a Fedora bug for the package, and then attach it to this tracker: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=F-ExcludeArch-ARM > > > > Then add ExcludeArch to the package, mentioning the particular bug. > > I've never seen this actually result in the bug being fixed in leaf > packages. The bug that I'm actually fixing is that we haven't had a successful hfsplus-tools build in nearly a year. However I think you're quite right that this is unlikely to fix the LLVM on ARM bug. > > I'm going to go ahead and do this now, since otherwise we won't have > > hfsplus-tools at all for any user. > > This is inappropriate. The bug is in LLVM, not hfsplus-tools. Quoting > from the guidelines: > > "ExcludeArch should only be set when the architecture is not relevant > for the package, the package is non-functional on the architecture, or > the code does not compile cleanly for the architecture." > > The code compiles fine, LLVM then fucks up linking. It didn't even compile for me. The error was: clang -g3 -Wall -fblocks -I/home/rjones/d/fedora/hfsplus-tools/master/diskdev_cmds-540.1.linux3/BlocksRunTime -I/home/rjones/d/fedora/hfsplus-tools/master/diskdev_cmds-540.1.linux3/include -DDEBUG_BUILD=0 -D_FILE_OFFSET_BITS=64 -D LINUX=1 -D BSD=1 -D VERSION=\"540.1.linux3\" -c -o runtime.o runtime.c clang: warning: unknown platform, assuming -mfloat-abi=soft In file included from runtime.c:26: In file included from /usr/include/stdio.h:27: In file included from /usr/include/features.h:388: /usr/include/gnu/stubs.h:7:11: fatal error: 'gnu/stubs-soft.h' file not found # include <gnu/stubs-soft.h> ^ 1 error generated. make[1]: *** [runtime.o] Error 1 The relevant bit of the package guidelines is this: If a Fedora package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number should then be placed in a comment, next to the corresponding ExcludeArch line. which I've now done, and the package is now built in Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=7033081 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
