Hi Tomi, On Fri, May 03, 2019 at 11:10:54AM +0300, Tomi Valkeinen wrote: > On 21/04/2019 01:14, Laurent Pinchart wrote: > > On Tue, Mar 26, 2019 at 12:31:40PM +0200, Tomi Valkeinen wrote: > >> tc_main_link_enable() checks if videomode has been set, and fails if > >> there's no videomode. As tc_main_link_enable() no longer depends on the > >> videomode, we can drop the check. > > > > Shouldn't you move the check to the stream enable function ? Or if it's > > not needed there, explain why in the commit message ? > > True. I believe it is not needed. I don't think bridge_enable should be > called at all, if there has not been a mode set before it. If there's no > mode, bridge enable presumably would fail for any bridge... That's my understanding too. A quick check in the core could be useful, and mentioning this in the commit message too. Ideally the documentation of the bridge operations should be updated to make this clear :-) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
