Hi Tomi, Thank you for the patch. On Tue, Mar 26, 2019 at 12:31:40PM +0200, Tomi Valkeinen wrote: > tc_main_link_enable() checks if videomode has been set, and fails if > there's no videomode. As tc_main_link_enable() no longer depends on the > videomode, we can drop the check. Shouldn't you move the check to the stream enable function ? Or if it's not needed there, explain why in the commit message ? > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > --- > drivers/gpu/drm/bridge/tc358767.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c > index 1c61f6205e43..ece330c05b9f 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -776,10 +776,6 @@ static int tc_main_link_enable(struct tc_data *tc) > u8 tmp[8]; > u32 error; > > - /* display mode should be set at this point */ > - if (!tc->mode) > - return -EINVAL; > - > dev_dbg(tc->dev, "link enable\n"); > > tc_write(DP0CTL, 0); -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
