On 21/04/2019 01:14, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Mar 26, 2019 at 12:31:40PM +0200, Tomi Valkeinen wrote: >> tc_main_link_enable() checks if videomode has been set, and fails if >> there's no videomode. As tc_main_link_enable() no longer depends on the >> videomode, we can drop the check. > > Shouldn't you move the check to the stream enable function ? Or if it's > not needed there, explain why in the commit message ? True. I believe it is not needed. I don't think bridge_enable should be called at all, if there has not been a mode set before it. If there's no mode, bridge enable presumably would fail for any bridge... Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
