Hi Tomi,
Thank you for the patch.
On Tue, Mar 26, 2019 at 12:31:41PM +0200, Tomi Valkeinen wrote:
> We have tc_connector_mode_valid() to filter out videomdoes that the
> tc358767 cannot support. As it is a bridge limitation, change the code
> to use drm_bridge_funcs's mode_valid instead.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/tc358767.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index ece330c05b9f..9fbda370a4c2 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -1140,10 +1140,10 @@ static bool tc_bridge_mode_fixup(struct drm_bridge *bridge,
> return true;
> }
>
> -static enum drm_mode_status tc_connector_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> +static enum drm_mode_status tc_mode_valid(struct drm_bridge *bridge,
> + const struct drm_display_mode *mode)
> {
> - struct tc_data *tc = connector_to_tc(connector);
> + struct tc_data *tc = bridge_to_tc(bridge);
> u32 req, avail;
> u32 bits_per_pixel = 24;
>
> @@ -1212,7 +1212,6 @@ tc_connector_best_encoder(struct drm_connector *connector)
>
> static const struct drm_connector_helper_funcs tc_connector_helper_funcs = {
> .get_modes = tc_connector_get_modes,
> - .mode_valid = tc_connector_mode_valid,
> .best_encoder = tc_connector_best_encoder,
> };
>
> @@ -1255,6 +1254,7 @@ static int tc_bridge_attach(struct drm_bridge *bridge)
>
> static const struct drm_bridge_funcs tc_bridge_funcs = {
> .attach = tc_bridge_attach,
> + .mode_valid = tc_mode_valid,
> .mode_set = tc_bridge_mode_set,
> .pre_enable = tc_bridge_pre_enable,
> .enable = tc_bridge_enable,
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
