Hi Tomi,
Thank you for the patch.
On Tue, Mar 26, 2019 at 12:31:42PM +0200, Tomi Valkeinen wrote:
> As far as I know, drm_connector_helper_funcs.best_encoder is not needed
> in a trivial case as we have here. So remove tc_connector_best_encoder.
I would add that the operation is only needed when the connector has
more than one encoder, which can't be the case here.
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> ---
> drivers/gpu/drm/bridge/tc358767.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index 9fbda370a4c2..114d535c296b 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -1202,17 +1202,8 @@ static void tc_connector_set_polling(struct tc_data *tc,
> DRM_CONNECTOR_POLL_DISCONNECT;
> }
>
> -static struct drm_encoder *
> -tc_connector_best_encoder(struct drm_connector *connector)
> -{
> - struct tc_data *tc = connector_to_tc(connector);
> -
> - return tc->bridge.encoder;
> -}
> -
> static const struct drm_connector_helper_funcs tc_connector_helper_funcs = {
> .get_modes = tc_connector_get_modes,
> - .best_encoder = tc_connector_best_encoder,
> };
>
> static const struct drm_connector_funcs tc_connector_funcs = {
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
