On 03/05/2019 15:55, Laurent Pinchart wrote:
>>>>
>>>> - if (state) {
>>>> - ret = tc_set_video_mode(tc, tc->mode);
>>>> - if (ret)
>>>> - goto err;
>>>> + ret = tc_set_video_mode(tc, tc->mode);
>>>> + if (ret)
>>>> + goto err;
>>>
>>> Let's return ret directly and remove the err label.
>>
>> Can't remove the err label, because of the tc_write() calls...
>
> :-(
>
> I'd love to see this getting fixed. The best way I've found so far would
> be
And by fixed you mean cleaned up?
Yes, it's a mess. That's why I want to get this series merged asap, so
Andrey can rebase his series, and we can proceed with all the cleanups
=). His series removes these macros that require the err label.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
