On Mon, Dec 09, 2024 at 03:11:29PM +0800, Chen Wang wrote: > + msi-controller: true > + > + msi-ranges: > + maxItems: 1 > + > + sophgo,msi-doorbell-addr: > + description: > + u64 value of the MSI doorbell address > + $ref: /schemas/types.yaml#/definitions/uint64 reg, as asked last time. 'reg' does not mean you need to ioremap it. > + > +required: > + - compatible > + - reg > + - reg-names > + - msi-controller > + - msi-ranges > + - sophgo,msi-doorbell-addr > + > +additionalProperties: true Nope, this cannot be true. There is no single device binding like that, so do not introduce your own conventions. > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + msi: msi-controller@30000000 { Drop unused label. Best regards, Krzysztof