Re: [PATCH v2 1/3] dt-bindings: interrupt-controller: Add Sophgo SG2042 MSI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2024/12/9 17:28, Krzysztof Kozlowski wrote:
On Mon, Dec 09, 2024 at 03:11:29PM +0800, Chen Wang wrote:
+  msi-controller: true
+
+  msi-ranges:
+    maxItems: 1
+
+  sophgo,msi-doorbell-addr:
+    description:
+      u64 value of the MSI doorbell address
+    $ref: /schemas/types.yaml#/definitions/uint64
reg, as asked last time. 'reg' does not mean you need to ioremap it.
Ok, I will fix this in next version.
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - msi-controller
+  - msi-ranges
+  - sophgo,msi-doorbell-addr
+
+additionalProperties: true
Nope, this cannot be true. There is no single device binding like that,
so do not introduce your own conventions.
Got, will fix it.

+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    msi: msi-controller@30000000 {
Drop unused label.
Got, thanks.

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux