Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, Oct 23, 2014 at 02:01:03PM +0100, Mark Brown wrote:
> On Thu, Oct 23, 2014 at 12:14:43PM +0900, Gyungoh Yoo wrote:
> 
> > So, what do you think about DT like below?
> 
> > sky81452@2c {
> > 	compatible = "skyworks,sky81452";
> > 	reg = <0x2c>;
> > 
> > 	backlight {
> > 		compatible = "skyworks,sky81452-backlight";
> > 		name = "pwm-backlight";
> > 		enable = <0x3F>;
> > 		ignore-pwm;
> > 	};
> > 
> > 	regulator {
> > 		compatible = "skyworks,sky81452-regulator";
> 
> Yes, this is good but I still feel that the above compatible is
> redundant and shouildn't be there.

I see. I will remove compatible string at the next resubmit.

> 
> > 		lout@0 {
> > 			regulator-name = "LOUT";
> > 			regulator-min-microvolt = <4500000>;
> > 			regulator-max-microvolt = <8000000>;
> > 		};
> > 	};
> > };


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux