Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, Oct 17, 2014 at 06:19:50PM +0900, Gyungoh Yoo wrote:

> Wow. I understand.
> I missed .supply_name. I think I need something like
> below, before devm_regulator_register().

> 	config->supply_name = init_data->constraints.name;

> I will resubmit it.

No, not supply_name (though you really should be initializing that
anyway) and you definitely don't want to set supply_name to something
from constraints.  The supply_name should be the name of the input pin
that supplies power to the regulator.  I was referring to of_match and
regulators_node.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux