On Fri, Oct 17, 2014 at 07:43:09PM +0900, Gyungoh Yoo wrote: > Are you talking about simplification using of_regulator_match()? > This driver has only one regulator. > Is the API also useful for this driver? The thing I'm seeing is that the binding for your device with the subnode looks very much like the device trees of devices with multiple regulators. The fact that you only have one regulator is a bit difference but not that much. It seems like drivers should fit into one of two patterns: either the regulator is described in the root node for the device for single purpose devices or there should be a collection of regulators like is supported with this helper API. Having a collection with only one node doesn't seem to be a problem in any way. > Like reg-fixed-voltage, how about using of_get_fixed_voltage_config()? The driver doesn't seem to need any property parsing of its own so it shoudn't need anything beyond basic calls into the core.
Attachment:
signature.asc
Description: Digital signature
