On 30/04/2022 10:04, Mikhail Zhilkin wrote:
>
> diff --git
> a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> index ea4cace6a955..fa457d55559b 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> @@ -17,9 +17,29 @@ description: |
> maintainers:
> - Rafał Miłecki <rafal@xxxxxxxxxx>
>
> +select:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fixed-partitions
> +
> + required:
> + - compatible
With your approach you do not need this entire select. I pointed out to
you if you wanted to take the syscon approach.
> +
> properties:
> compatible:
> - const: fixed-partitions
> + anyOf:
oneOf
> + - items:
> + - enum:
> + - sercomm,sc-partitions
> +
> + - const: fixed-partitions
> +
> + - contains:
> + const: fixed-partitions
> + minItems: 1
> + maxItems: 2
This is also not needed if you do no take the syscon approach.
>
> "#address-cells": true
>
> @@ -27,7 +47,18 @@ properties:
>
> patternProperties:
> "@[0-9a-f]+$":
> - $ref: "partition.yaml#"
> + allOf:
> + - $ref: "partition.yaml#"
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: sercomm,sc-partitions
> + then:
> + properties:
> + sercomm,scpart-id:
> + description: Partition id in Sercomm partition map
> + $ref: /schemas/types.yaml#/definitions/uint32
I think we still did not clarify why do you need this ID which in all
your examples increments by one. The description basically is a copy of
property name, so it does not explain anything.
>
> required:
> - "#address-cells"
> @@ -119,3 +150,29 @@ examples:
> };
> };
> };
Blank line.
> + - |
> + partitions {
> + compatible = "sercomm,sc-partitions", "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "u-boot";
> + reg = <0x0 0x100000>;
> + sercomm,scpart-id=<0>;
Missing spaces around =.
Best regards,
Krzysztof
