On 06/04/2022 21:59, Mikhail Zhilkin wrote: > Add YAML binding for Sercomm partition parser. > > Signed-off-by: Mikhail Zhilkin <csharper2005@xxxxxxxxx> > --- > .../mtd/partitions/sercomm,sc-partitions.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/sercomm,sc-partitions.yaml > (...) > + > +properties: > + compatible: > + const: sercomm,sc-partitions > + > + scpart-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Partition id in Sercomm partition map Do you really need it? The reg should define the order, unless you expect some incomplete partition list? In any case this requires vendor prefix. > + > +required: > + - compatible Missing reg. > + - scpart-id > + > +additionalProperties: false Are you sure that you tested your bindings? You miss here address/size cells and children, so you should have big fat warning. Plus your DTS example has error and does not compile... Best regards, Krzysztof
