On 09/04/2022 20:17, Mikhail Zhilkin wrote: > > On 4/9/2022 9:04 PM, Mikhail Zhilkin wrote: >>>>>> +required: >>>>>> + - compatible >>>>> Missing reg. >>>> reg isn't required. Parser can read partition offsets and sizes from >>>> SC PART MAP table. Or do you mean something else? All is ok >>>> without reg definition in "Example" (except the warns that reg property >>>> is missing). >>> reg might not be required for current implementation but it is required >>> by devicetree for every node with unit address. Do you expect here nodes >>> without unit addresses? >> Only "partitions" node has no unit address. All subnodes have unit >> addresses and therefore have to have reg property. I've just realized >> that "fixed-partitions.yaml" is almost my case. It looks like I can >> copy'n'paste "required" and "*properties". >> Do you mind if I don't reinvent the wheel and reuse this good >> practice? >> >> Here's what I got (no any warnings appears): > > > I'm sorry, Krzysztof & All. Here is the final one. I am sorry, but you changed now a lot in the bindings and it looks entirely different. Things previously being correct now are wrong, so rather start from your old bindings... > > --- > .../mtd/partitions/sercomm,sc-partitions.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/mtd/partitions/sercomm,sc-partitions.yaml > > diff --git > a/Documentation/devicetree/bindings/mtd/partitions/sercomm,sc-partitions.yaml > b/Documentation/devicetree/bindings/mtd/partitions/sercomm,sc-partitions.yaml > new file mode 100644 > index 000000000000..33172f0be92a > --- /dev/null > +++ > b/Documentation/devicetree/bindings/mtd/partitions/sercomm,sc-partitions.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: > http://devicetree.org/schemas/mtd/partitions/sercomm,sc-partitions.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sercomm Partitions > + > +description: | > + Sercomm is one of hardware manufacturers providing SoCs used in home > routers. > + The Sercomm partition map table contains information about non-standard > + partition offsets and sizes (depending on the bad blocks presence and > their > + locations). Partition map is used by many Sercomm-based Ralink > devices (e.g. > + Beeline, Netgear). > + > + The partition table should be a node named "partitions". Partitions > are then > + defined as subnodes. > + > +maintainers: > + - Mikhail Zhilkin <csharper2005@xxxxxxxxx> > + > +properties: > + compatible: > + const: sercomm,sc-partitions > + > + "#address-cells": true > + > + "#size-cells": true > + > +patternProperties: > + "@[0-9a-f]+$": > + $ref: "partition.yaml#" > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" Still missing reg. > + > +additionalProperties: true This is wrong, why it became true? Best regards, Krzysztof
