On 09/04/2022 20:04, Mikhail Zhilkin wrote: > On 4/9/2022 3:43 PM, Krzysztof Kozlowski wrote: > >>> I'm not sure that "scpart-id" is necessary here. "sercomm,sc-partitions" >>> is necessary. I'm going to add vendor prefix in a separate patch. Is this >>> ok? >> Yes. > > Thanks! > >>>>> +required: >>>>> + - compatible >>>> Missing reg. >>> reg isn't required. Parser can read partition offsets and sizes from >>> SC PART MAP table. Or do you mean something else? All is ok >>> without reg definition in "Example" (except the warns that reg property >>> is missing). >> reg might not be required for current implementation but it is required >> by devicetree for every node with unit address. Do you expect here nodes >> without unit addresses? > Only "partitions" node has no unit address. This confused me. Do you have a child node named "partitions"? > All subnodes have unit > addresses and therefore have to have reg property. So all of them need reg. > I've just realized > that "fixed-partitions.yaml" is almost my case. It looks like I can > copy'n'paste "required" and "*properties". > Do you mind if I don't reinvent the wheel and reuse this good > practice? Re-using proper stuff is good, but just don't blindly copy. You need still compatible and reg in required properties. Best regards, Krzysztof
