On 11/01/2022 23:00, David Heidelberg wrote: > Convert Qualcomm SPMI PMIC binding to yaml format. > > Additional changes: > - filled many missing compatibles > > Co-developed-by: Caleb Connolly <caleb@xxxxxxxxxxxxx> > Signed-off-by: David Heidelberg <david@xxxxxxx> > --- Thank you for your patch. There is something to discuss/improve. (...) > + > + compatible: > + items: > + - enum: > + - qcom,pm660 > + - qcom,pm660l > + - qcom,pm6150 > + - qcom,pm6150l > + - qcom,pm6350 > + - qcom,pm7325 > + - qcom,pm8004 > + - qcom,pm8005 > + - qcom,pm8009 > + - qcom,pm8019 > + - qcom,pm8110 > + - qcom,pm8150 > + - qcom,pm8150b > + - qcom,pm8150l > + - qcom,pm8226 > + - qcom,pm8350 > + - qcom,pm8350b > + - qcom,pm8350c > + - qcom,pm8841 > + - qcom,pm8909 > + - qcom,pm8916 > + - qcom,pm8941 > + - qcom,pm8950 > + - qcom,pm8994 > + - qcom,pm8998 > + - qcom,pma8084 > + - qcom,pmd9635 > + - qcom,pmi8950 > + - qcom,pmi8962 > + - qcom,pmi8994 > + - qcom,pmi8998 > + - qcom,pmk8350 > + - qcom,pmm8155au > + - qcom,pmr735a > + - qcom,pmr735b > + - qcom,pms405 > + - qcom,pmx55 > + - qcom,smb2351 > + - const: qcom,spmi-pmic > + > + reg: true maxItems > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + Just one blank line. > +patternProperties: > + '^(labibb|([a-z][a-z0-9]+-)?regulators)$': > + type: object > + This should be more specific, preferably by including schema for regulators (or any other children if applicable). > + required: > + - compatible unevaluatedProperties: false > + > + '@[0-9a-f]+$': > + type: object > + description: > You don't need '>'. This also should be specified - what is expected to be here? Usually the children are exactly known. > + Each child node of the PMIC represents a function of it. > + > + properties: > + reg: true maxItems > + > + interrupts: > + description: > No need for > > + Interrupts are specified as a 4-tuple. For more information see > + Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml > + > + required: > + - compatible > + > + additionalProperties: true This will have to unevaluated or additional properties false, depending whether you include other schema or not. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + Best regards, Krzysztof
