On 31/01/2022 22:26, Bjorn Andersson wrote: > On Sat 18 Dec 13:40 CST 2021, David Heidelberg wrote: > >> Convert Qualcomm SCM firmware binding to the yaml format. >> >> Signed-off-by: David Heidelberg <david@xxxxxxx> >> --- >> This patch comes with followup question -> since not all definitions >> follow `"qcom,scm-*chipset*", "qcom,scm"`, should I change them or adjust this >> binding to cover all cases? >> > > I don't remember why some platforms has the generic "fallback" and > others doesn't. I don't have any objections to defining the binding as > you've done. Looking at the driver it seems that there some differences between certain versions and generic qcom,scm. For example they require bus clock which could mean they won't work without it on a "qcom,scm" compatible. That could mean that original "qcom,scm" also required that bus clock but it was for example always enabled. Or that clock was never needed on "qcom,scm". I think this should be converted without generic fallback, IOW, the original bindings are not accurate and driver+DTS are better hints how it should work. Best regards, Krzysztof
