On 28/04/2022 17:24, Mikhail Zhilkin wrote: > > Hi, Krzysztof, > > On 4/10/2022 11:18 AM, Krzysztof Kozlowski wrote: >> I am sorry, but you changed now a lot in the bindings and it looks >> entirely different. Things previously being correct now are wrong, so >> rather start from your old bindings... > > > Looks like I'm a bit confused... I use dual "compatible" in my real dts > and I realized that: > > 1. Therefore I have to use dual "compatible" in example too: > > compatible = "sercomm,sc-partitions", "fixed-partitions"; > > 2. When I'm trying to reuse "fixed-partitions" compatible from > fixed-partitions.yaml in my new .yaml I get "too long" errors. Yes, the fixed-partitions.yaml would have to be changed to allow extension. > > Real dts: > > Link: > https://github.com/openwrt/openwrt/blob/edcc1a9a734bb3fcdc9242025290d3f173e71b78/target/linux/ramips/dts/mt7621_beeline_smartbox-giga.dts#L79 > > So, I currently found another solution - to extend fixed-partitions.yaml > with "sercomm,sc-partitions". Is It ok from your side? Can I use this > code in v3? Not really, I don't understand why do you need it and it does not include our previous talks. > > diff --git > a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml > b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml > index ea4cace6a955..9eebe39a57fb 100644 > --- a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml > +++ b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml > @@ -19,7 +19,11 @@ maintainers: > > properties: > compatible: > - const: fixed-partitions > + oneOf: > + - const: fixed-partitions > + - items: > + - const: sercomm,sc-partitions > + - const: fixed-partitions > > "#address-cells": true > > @@ -27,7 +31,18 @@ properties: > > patternProperties: > "@[0-9a-f]+$": > - $ref: "partition.yaml#" > + allOf: > + - $ref: "partition.yaml#" > + - if: > + properties: > + compatible: > + contains: > + const: sercomm,sc-partitions > + then: > + properties: > + scpart-id: It still misses vendor prefix and we agreed you don't need it, didn't we? Best regards, Krzysztof
