On Sat, Jun 13, 2009 at 06:44, Mark Brown wrote:> On Sat, Jun 13, 2009 at 11:37:33AM +0200, Karl Beldan wrote:>> This - f692fce - should not have reached upstream, how come ?>> The entire discussion of the patch occurred in response to my saying I'd> applied it, with most of the discussion being a couple of days later> after it'd have already gone into ALSA. Since nobody asked to have it> reverted or indicated that there was any actual problem other than a> repitition of code it wasn't reverted. For the most part repitition> in ASoC would just be a no-op and therefore a code quality rather> than behavioural issue. As I indicated when accepting the patch I've> lowered my standards there for blackfin due to the past issues with> iteration speed (which Mike has already said will be being addressed> now).>> I've now reverted the shutdown hunk of the patch where duplication will> actually introduce a bug. i think Cliff verified that the other part of the change was no longerneeded in his testing, so reverting the whole patch is fine. we'vedone that in the Blackfin tree.-mike_______________________________________________Alsa-devel mailing listAlsa-devel@xxxxxxxxxxxxxxxxxxxx://mailman.alsa-project.org/mailman/listinfo/alsa-devel
