Re: [PATCH] ASoC: rcar: adg: correct TIMSEL setting for SSI9

[Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>]

Hello Morimoto-san,

On Thu, Feb 29, 2024 at 12:16:09AM +0000, Kuninori Morimoto wrote:
> > > A number of concerns have been raised internally, related to the fact
> > > that the "optimized/simplified" counter-proposal behaves differently
> > > depending on the value returned by rsnd_ssi_is_pin_sharing().
> (snip)
> > Could you please indicate the sample case of differently behaves ?
> > For example, if xxx was xxx, original code behaves xxx, but simple
> > code behaves xxx, etc. I'm not sure what is your concern...
> 
> Ah.., in case of SSI8.
> 
> > > While it may be clear for you that pin sharing is mandatory, it is not
> > > immediately obvious to the casual reader/contributor purely based on
> > > code review.
> 
> SSI8 with pin sharing is not only this function issue,
> you can see same comment on rsnd_adg_set_ssi_clk().
> # It is not clear for me either, I have been forgot about it :)
> # and I have never use SSI8 before, so I'm not sure what happen
> # if someone use it
> 
> If you have concern about it, why don't you add such error/message
> when begining time, instead of each functions ?
> Because of compatibility, rsnd_ssi_probe() is not good place,
> so I think rsnd_ssi_connect() is good place.

Thanks for your patience and for accepting different viewpoints,
while discussing the issue. Please, kindly review v2:

https://lore.kernel.org/linux-sound/20240301085003.3057-1-erosca@xxxxxxxxxxxxxx

BR, Eugeniu