Re: [PATCH] ASoC: rcar: adg: correct TIMSEL setting for SSI9

[Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>]

Hello Morimoto-san,

Thank you for the prompt response.

On Sun, Feb 25, 2024 at 11:21:16PM +0000, Kuninori Morimoto wrote:

[..]

> >  
> > -	return (0x6 + ws) << 8;
> > +	if (id > 9)
> > +		return 0xf << 8;
> > +	else
> > +		return ssi_ws[id] << 8;
> >  }
> 
> I don't think we want to have table for this purpose.
> SSIx special handling exist every where on this IP.
> 
> How about below ? It is more simple.
> 
> ---------------------------------
> diff --git a/sound/soc/sh/rcar/adg.c b/sound/soc/sh/rcar/adg.c
> index 230c48648af3..bbc7845c68b3 100644
> --- a/sound/soc/sh/rcar/adg.c
> +++ b/sound/soc/sh/rcar/adg.c
> @@ -113,6 +113,13 @@ static u32 rsnd_adg_ssi_ws_timing_gen2(struct rsnd_dai_stream *io)
>  		}
>  	}
>  
> +	/*
> +	 * SSI8 is not connected to ADG.
> +	 * Thus SSI9 is using 8
> +	 */
> +	if (id == 9)
> +		ws = 8;
> +
>  	return (0x6 + ws) << 8;
>  }
> ---------------------------------

Appreciate very much the simpler counter-proposal.

Quick/preliminary verification attempts showed that it might not be
fully equivalent to the original patch, but we are still trying to
get that finally confirmed or invalidated. Will keep you posted.

BR, Eugeniu