Re: [PATCH] ASoC: rcar: adg: correct TIMSEL setting for SSI9

[Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>]

Hi Eugeniu

> > > > +	/*
> > > > +	 * SSI8 is not connected to ADG.
> > > > +	 * Thus SSI9 is using 8
> > > > +	 */
> > > > +	if (id == 9)
> > > > +		ws = 8;
> > (snip)
> > > Quick/preliminary verification attempts showed that it might not be
> > > fully equivalent to the original patch
> > 
> > If it is indicating that above simple code doesn't care about
> > SSI8 error case, I don't think it needs to care about it.
> 
> A number of concerns have been raised internally, related to the fact
> that the "optimized/simplified" counter-proposal behaves differently
> depending on the value returned by rsnd_ssi_is_pin_sharing().
>
> While it may be clear for you that pin sharing is mandatory, it is not
> immediately obvious to the casual reader/contributor purely based on
> code review. From this particular viewpoint, I would rather vote in
> favor of the original patch authored by Andreas (Cc), since it makes
> things very clear and does not hide any dependencies/assumptions.

Hmm.. ?
Could you please indicate the sample case of differently behaves ?
For example, if xxx was xxx, original code behaves xxx, but simple
code behaves xxx, etc. I'm not sure what is your concern...
For me, original code is solving simple problems in complex ways
by using much memory.


Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto